Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:steps): do not run change detection if there are no nzIndexChange listeners #7183

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Jan 3, 2022

PR Checklist

PR Type

[x] Refactoring (no functional changes, no api changes)
[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Jan 3, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #7183 (72bb628) into master (77db914) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7183      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.01%     
==========================================
  Files         486      486              
  Lines       15868    15867       -1     
  Branches     2587     2586       -1     
==========================================
- Hits        14547    14545       -2     
- Misses       1007     1008       +1     
  Partials      314      314              
Impacted Files Coverage Δ
components/steps/step.component.ts 96.00% <100.00%> (+0.08%) ⬆️
components/steps/steps.component.ts 94.80% <100.00%> (-0.14%) ⬇️
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77db914...72bb628. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit cbfc558 into NG-ZORRO:master Jan 17, 2022
@arturovt arturovt deleted the perf/steps-click branch January 17, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants