Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:icon): fix old icon element not removed #7188

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 5, 2022

close #7186

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 5, 2022

This preview will be available after the AzureCI is passed.

@wzhudev wzhudev requested a review from arturovt January 5, 2022 09:10
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.65%. Comparing base (77db914) to head (66b3a6b).
Report is 757 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7188      +/-   ##
==========================================
- Coverage   91.67%   91.65%   -0.02%     
==========================================
  Files         486      486              
  Lines       15868    15870       +2     
  Branches     2587     2587              
==========================================
- Hits        14547    14546       -1     
- Misses       1007     1009       +2     
- Partials      314      315       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar collapse icon issue
3 participants