Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input): do not set box-sizing when measuring #7214

Conversation

stingshen
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7203

What is the new behavior?

The textarea auto resizes correctly

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 17, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #7214 (b0ff89a) into master (69c6258) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b0ff89a differs from pull request most recent head ad1084f. Consider uploading reports for the commit ad1084f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7214      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         486      486              
  Lines       15918    15918              
  Branches     2588     2588              
==========================================
- Hits        14602    14601       -1     
- Misses       1003     1004       +1     
  Partials      313      313              
Impacted Files Coverage Δ
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c6258...ad1084f. Read the comment docs.

@stingshen stingshen force-pushed the stingshen/textarea-autosize-measuring-box-sizing branch 5 times, most recently from 63f2dff to e03d9c0 Compare January 19, 2022 16:16
@stingshen stingshen force-pushed the stingshen/textarea-autosize-measuring-box-sizing branch from e03d9c0 to ad1084f Compare January 19, 2022 16:38
@stingshen
Copy link
Contributor Author

@vthinkxie PTAL

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wenqi73 wenqi73 merged commit 035dc94 into NG-ZORRO:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants