Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:i18n): add km_KH #7220

Merged
merged 3 commits into from
Feb 21, 2022
Merged

feat(module:i18n): add km_KH #7220

merged 3 commits into from
Feb 21, 2022

Conversation

SamnangNhum
Copy link
Contributor

@SamnangNhum SamnangNhum commented Jan 19, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

No km_KH i18n

What is the new behavior?

Add km_KH i18n

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: draft label Jan 19, 2022
@zorro-bot
Copy link

zorro-bot bot commented Jan 19, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #7220 (ed22d8d) into master (e541761) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7220      +/-   ##
==========================================
- Coverage   91.72%   91.71%   -0.02%     
==========================================
  Files         486      486              
  Lines       15950    15950              
  Branches     2591     2591              
==========================================
- Hits        14630    14628       -2     
- Misses       1010     1011       +1     
- Partials      310      311       +1     
Impacted Files Coverage Δ
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e541761...ed22d8d. Read the comment docs.

@SamnangNhum SamnangNhum changed the title feat: add km_kh to i18n feat: add km_KH to i18n Jan 19, 2022
@SamnangNhum SamnangNhum marked this pull request as ready for review January 19, 2022 08:46
@SamnangNhum SamnangNhum changed the title feat: add km_KH to i18n feat(module:i18n): add km_KH translation Jan 19, 2022
@SamnangNhum SamnangNhum changed the title feat(module:i18n): add km_KH translation feat(module:i18n): add km_KH Jan 19, 2022
@wenqi73
Copy link
Member

wenqi73 commented Feb 15, 2022

@SamnangNhum Could you help to update docs/i18n.zh-CN.md and docs/i18n.en-US.md?

@wenqi73 wenqi73 mentioned this pull request Feb 15, 2022
@SamnangNhum SamnangNhum requested a review from a team as a code owner February 17, 2022 04:27
@SamnangNhum
Copy link
Contributor Author

@SamnangNhum Could you help to update docs/i18n.zh-CN.md and docs/i18n.en-US.md?

@wenqi73 I have already updated docs please checked thanks

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamnangNhum Thanks!

@simplejason
Copy link
Member

@SamnangNhum Can you rebase with master to resolve these conflicts? After that, @wenqi73 please recheck this PR :)

@wenqi73 wenqi73 merged commit f972391 into NG-ZORRO:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants