Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix keyboard event error when option data is empty #7222

merged 3 commits into from
Feb 18, 2022


Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7216

What is the new behavior?

Does not do anything, if option data is null

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

zorro-bot bot commented Jan 19, 2022

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #7222 (bc039e7) into master (662648c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head bc039e7 differs from pull request most recent head 229e168. Consider uploading reports for the commit 229e168 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7222      +/-   ##
+ Coverage   91.72%   91.75%   +0.03%     
  Files         486      486              
  Lines       15918    15920       +2     
  Branches     2588     2588              
+ Hits        14601    14608       +7     
+ Misses       1004     1001       -3     
+ Partials      313      311       -2     
Impacted Files Coverage Δ
...mponents/date-picker/date-range-popup.component.ts 95.16% <100.00%> (+1.10%) ⬆️
components/select/select.component.ts 90.82% <100.00%> (+0.63%) ⬆️
components/slider/slider.component.ts 92.27% <100.00%> (+0.02%) ⬆️
components/core/util/text-measure.ts 92.98% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662648c...229e168. Read the comment docs.

@chenc041 chenc041 changed the title fix(module:select): fix keyboard event error when option data is null fix(module:select): fix keyboard event error when option data is empty Feb 8, 2022
components/select/select.component.ts Outdated Show resolved Hide resolved
Copy link

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@simplejason simplejason merged commit 4bd86ca into NG-ZORRO:master Feb 18, 2022
@chenc041 chenc041 deleted the fix-select-keyenvent-error branch June 7, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants