Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:drawer): support new apis nzSize and nzExtra #7227

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

yangjunhan
Copy link
Contributor

close #7226

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7226

What is the new behavior?

Support nzSize and nzExtra

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Default width and height changes from 250px to 378px.

@zorro-bot
Copy link

zorro-bot bot commented Jan 21, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #7227 (2c00a59) into master (662648c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2c00a59 differs from pull request most recent head 6ba01ef. Consider uploading reports for the commit 6ba01ef to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7227   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         486      487    +1     
  Lines       15918    15925    +7     
  Branches     2588     2592    +4     
=======================================
+ Hits        14601    14608    +7     
  Misses       1004     1004           
  Partials      313      313           
Impacted Files Coverage Δ
components/drawer/drawer-options.ts 100.00% <100.00%> (ø)
components/drawer/drawer.component.ts 98.55% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662648c...6ba01ef. Read the comment docs.

@simplejason simplejason merged commit d2e5b76 into NG-ZORRO:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drawer supports new apis in order to keep synchronous with ant design
2 participants