perf(module:modal): call focus() on the next rendering frame to prevent frame drop
#7293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7293 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 487 487
Lines 16006 16006
Branches 2604 2604
=======================================
Hits 14662 14662
Misses 1032 1032
Partials 312 312
Continue to review full report at Codecov.
|
…vent frame drop Calling `focus()` on the element causes browsers to do re-layouts. This can been seen here: https://gist.github.com/paulirish/5d52fb081b3570c81e3a#setting-focus Microtasks are executed asynchronously, but within the current rendering frame. Using `requestAnimationFrame` except of `Promise.resolve` basically unloads the current frame and calls `focus()` on the next rendering frame, this prevent frame drops on slower devices when the modal is opened.
arturovt
force-pushed
the
perf/modal-focus-next-frame
branch
from
3c92171
to
8d7adbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
focus()on the element causes browsers to do re-layouts. This can been seen here:https://gist.github.com/paulirish/5d52fb081b3570c81e3a#setting-focus
Microtasks are executed asynchronously, but within the current rendering frame. Using
requestAnimationFrameexcept of
Promise.resolvebasically unloads the current frame and callsfocus()on the next renderingframe, this prevent frame drops on slower devices when the modal is opened:
Flame graph
Reason