Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): update position when click menu item #7306

Merged
merged 9 commits into from
Apr 21, 2022
Merged

fix(module:cascader): update position when click menu item #7306

merged 9 commits into from
Apr 21, 2022

Conversation

yutao331763646
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 9, 2022

This preview will be available after the AzureCI is passed.

@yutao331763646
Copy link
Contributor Author

image

与antd表现不一致

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #7306 (edad65d) into master (2d77bc2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7306      +/-   ##
==========================================
+ Coverage   91.59%   91.60%   +0.01%     
==========================================
  Files         487      487              
  Lines       16006    16007       +1     
  Branches     2604     2604              
==========================================
+ Hits        14660    14663       +3     
+ Misses       1033     1032       -1     
+ Partials      313      312       -1     
Impacted Files Coverage Δ
components/cascader/cascader.service.ts 99.51% <ø> (ø)
components/core/overlay/overlay-position.ts 90.90% <ø> (ø)
components/cascader/cascader.component.ts 97.98% <100.00%> (+<0.01%) ⬆️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d77bc2...edad65d. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@yutao331763646
Copy link
Contributor Author

目前的问题,如下图,当下拉选项超出屏幕时,会被遮挡
image

@yutao331763646
Copy link
Contributor Author

修改之后:自动调整位置,使其剧中,和antd react体验保持一致,如下图
image

@yutao331763646 yutao331763646 changed the title docs(module:tooltip): fix typo fix(module:cascader): update position when click menu item Mar 10, 2022
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants