Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:cascader): do not run change detection on change event #7312

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

arturovt
Copy link
Member

No description provided.

@zorro-bot
Copy link

zorro-bot bot commented Mar 10, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #7312 (280a5eb) into master (d8ec154) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 280a5eb differs from pull request most recent head 1503ae9. Consider uploading reports for the commit 1503ae9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7312      +/-   ##
==========================================
- Coverage   91.60%   91.59%   -0.01%     
==========================================
  Files         487      487              
  Lines       16006    16017      +11     
  Branches     2604     2605       +1     
==========================================
+ Hits        14662    14671       +9     
- Misses       1032     1033       +1     
- Partials      312      313       +1     
Impacted Files Coverage Δ
components/cascader/cascader.component.ts 98.03% <100.00%> (+0.06%) ⬆️
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ec154...1503ae9. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit cb803f9 into NG-ZORRO:master Apr 21, 2022
@arturovt arturovt deleted the perf/cascader-change branch April 30, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants