-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:image): nz-image add press left
or right
to switch image
#7321
Conversation
The nz-image add nzEnableLeftRightArrow to support press `left` or `right` to switch image
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7321 +/- ##
==========================================
+ Coverage 91.59% 91.62% +0.03%
==========================================
Files 487 487
Lines 16006 16019 +13
Branches 2604 2607 +3
==========================================
+ Hits 14660 14678 +18
+ Misses 1033 1027 -6
- Partials 313 314 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议同时对单元测试的覆盖。
@@ -14,6 +14,7 @@ export class NzImagePreviewOptions { | |||
nzZoom?: number; | |||
nzRotate?: number; | |||
nzDirection?: Direction; | |||
nzEnableLeftRightArrow?: boolean = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不建议增加该字段, nzKeyboard
本身就是表示是否键盘操作,这里增加一个额外字段,倘若鼠标中间键切换时是不是也应该有另一个字段;因此容易产生歧义,以其如此,不如直接使用 nzKeyboard
来判断足够了。
The nz-image add support press `left` or `right` to switch image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cc @stygian-desolator
LGTM |
👍 |
The nz-image add nzEnableLeftRightArrow to support press
left
orright
to switch imagePR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information