Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:anchor): mark scroll listener as passive #7330

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

arturovt
Copy link
Member

No description provided.

@arturovt arturovt requested a review from cipchk as a code owner March 22, 2022 03:44
@zorro-bot
Copy link

zorro-bot bot commented Mar 22, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #7330 (4c9d20f) into master (2d77bc2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7330      +/-   ##
==========================================
+ Coverage   91.59%   91.62%   +0.03%     
==========================================
  Files         487      487              
  Lines       16006    16014       +8     
  Branches     2604     2604              
==========================================
+ Hits        14660    14673      +13     
+ Misses       1033     1027       -6     
- Partials      313      314       +1     
Impacted Files Coverage Δ
components/anchor/anchor.component.ts 99.04% <100.00%> (+<0.01%) ⬆️
components/upload/upload.component.ts 92.59% <0.00%> (-1.90%) ⬇️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️
components/list/list-item-cell.ts 92.00% <0.00%> (+3.53%) ⬆️
components/table/src/table/tr-measure.component.ts 91.30% <0.00%> (+4.34%) ⬆️
...ts/table/src/table/table-inner-scroll.component.ts 83.82% <0.00%> (+4.41%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d77bc2...4c9d20f. Read the comment docs.

Copy link
Member

@cipchk cipchk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit aab060f into NG-ZORRO:master Apr 20, 2022
@arturovt arturovt deleted the perf/anchor-passive branch April 20, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants