Skip to content

feat(module:avatar): add loading and fetchpriority attributes - #7347

Merged
HyperLife1119 merged 4 commits into
NG-ZORRO:masterfrom
arturovt:feat/avatar-loading-fetch
Jun 27, 2025
Merged

HyperLife1119 merged 4 commits into
NG-ZORRO:masterfrom
arturovt:feat/avatar-loading-fetch

Conversation

@arturovt

@arturovt arturovt commented Apr 4, 2022

Copy link
Copy Markdown
Member

Closes #7274

@arturovt
arturovt requested a review from hsuanxyz as a code owner April 4, 2022 17:53
@codecov

codecov Bot commented Apr 4, 2022 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.05%. Comparing base (42bbb0c) to head (8d89f6f).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7347      +/-   ##
==========================================
+ Coverage   91.99%   92.05%   +0.06%     
==========================================
  Files         560      560              
  Lines       19617    19609       -8     
  Branches     3095     3095              
==========================================
+ Hits        18047    18052       +5     
+ Misses       1233     1218      -15     
- Partials      337      339       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simplejason

Copy link
Copy Markdown
Member

As caniuse->loading and caniuse->fetchpriority shown, these attributes have low compatibility for most browsers, I don't think we need built-in properties to support. What do you think about this @hsuanxyz ?

@Laffery Laffery added 🌐 caniuse blocked by browser compatibility Component: Avatar labels Jul 25, 2024

@Laffery Laffery left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the document about these new inputs and add test cases if possible?

@Laffery Laffery added this to the v20 milestone Jun 24, 2025

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119
HyperLife1119 merged commit ff8419f into NG-ZORRO:master Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add loading="lazy" to Avatar img element

4 participants