Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:code-editor): remove monaco-editor dependency in config.ts #7392

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

yangjunhan
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 27, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #7392 (55756e0) into master (99f4141) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7392   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         487      487           
  Lines       16043    16043           
  Branches     2610     2610           
=======================================
  Hits        14702    14702           
  Misses       1028     1028           
  Partials      313      313           
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f4141...55756e0. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants