Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transfer): add trackBy to the list and track by the hide property #7424

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

arturovt
Copy link
Member

No description provided.

@zorro-bot
Copy link

zorro-bot bot commented May 11, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #7424 (6706785) into master (ff8599b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 6706785 differs from pull request most recent head d8c886c. Consider uploading reports for the commit d8c886c to get more accurate results

@@            Coverage Diff             @@
##           master    #7424      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         487      487              
  Lines       16043    16045       +2     
  Branches     2610     2610              
==========================================
  Hits        14702    14702              
- Misses       1028     1029       +1     
- Partials      313      314       +1     
Impacted Files Coverage Δ
components/transfer/transfer-list.component.ts 96.82% <100.00%> (+0.10%) ⬆️
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff8599b...d8c886c. Read the comment docs.

@arturovt arturovt changed the title fix(transfer): do not use getter for validData since filters always returns a new array fix(transfer): add trackBy to the list and track by the hide property May 11, 2022
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@simplejason simplejason merged commit 0587236 into NG-ZORRO:master Jul 25, 2022
@arturovt arturovt deleted the fix/transfer-getter branch July 25, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants