Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:cascader): support setting status #7452

Merged
merged 1 commit into from
May 24, 2022

Conversation

simplejason
Copy link
Member

@simplejason simplejason commented May 23, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7389

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #7452 (d7908d5) into master (111abf3) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head d7908d5 differs from pull request most recent head cd764fb. Consider uploading reports for the commit cd764fb to get more accurate results

@@            Coverage Diff             @@
##           master    #7452      +/-   ##
==========================================
- Coverage   91.64%   91.61%   -0.04%     
==========================================
  Files         491      492       +1     
  Lines       16110    16127      +17     
  Branches     2483     2485       +2     
==========================================
+ Hits        14764    14774      +10     
- Misses       1034     1040       +6     
- Partials      312      313       +1     
Impacted Files Coverage Δ
components/cascader/cascader.component.ts 98.12% <100.00%> (+0.07%) ⬆️
components/core/util/status-util.ts 100.00% <100.00%> (ø)
...ts/table/src/table/table-inner-scroll.component.ts 79.41% <0.00%> (-4.42%) ⬇️
components/tabs/tab-nav-bar.component.ts 86.52% <0.00%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111abf3...cd764fb. Read the comment docs.

Copy link
Contributor

@yangjunhan yangjunhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants