Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:input): support setting status #7472

Merged
merged 4 commits into from
May 31, 2022

Conversation

simplejason
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7389

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 28, 2022

This preview will be available after the AzureCI is passed.

@simplejason simplejason requested review from yangjunhan and hsuanxyz and removed request for vthinkxie May 28, 2022 11:50
@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #7472 (0c9218a) into master (86b613f) will increase coverage by 0.01%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##           master    #7472      +/-   ##
==========================================
+ Coverage   91.57%   91.58%   +0.01%     
==========================================
  Files         496      496              
  Lines       16316    16344      +28     
  Branches     2531     2536       +5     
==========================================
+ Hits        14941    14969      +28     
+ Misses       1050     1049       -1     
- Partials      325      326       +1     
Impacted Files Coverage Δ
components/input/input-group.component.ts 98.63% <93.33%> (+0.35%) ⬆️
components/input/input.directive.ts 97.82% <100.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b613f...0c9218a. Read the comment docs.

@simplejason
Copy link
Member Author

cc @buqiyuan

@buqiyuan
Copy link
Collaborator

buqiyuan commented May 30, 2022

Hi~ @simplejason it LGTM!
image
Then should the tests related to InputGroup be moved to input-group.spec.ts?

Copy link
Contributor

@yangjunhan yangjunhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 999215e into NG-ZORRO:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants