Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:input-number): support input number group #7488

Merged
merged 4 commits into from
Jun 2, 2022

Conversation

simplejason
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #7488 (c513424) into master (40815ad) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7488      +/-   ##
==========================================
+ Coverage   91.58%   91.65%   +0.06%     
==========================================
  Files         496      498       +2     
  Lines       16418    16512      +94     
  Branches     2548     2559      +11     
==========================================
+ Hits        15037    15134      +97     
+ Misses       1057     1055       -2     
+ Partials      324      323       -1     
Impacted Files Coverage Δ
components/input-number/input-number.module.ts 100.00% <ø> (ø)
.../input-number/input-number-group-slot.component.ts 100.00% <100.00%> (ø)
...nents/input-number/input-number-group.component.ts 100.00% <100.00%> (ø)
components/input-number/input-number.component.ts 99.59% <100.00%> (+0.86%) ⬆️
components/core/util/text-measure.ts 92.98% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40815ad...c513424. Read the comment docs.

@simplejason simplejason merged commit b038fa2 into NG-ZORRO:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant