Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:anchor): sync new properties #7494

Merged
merged 1 commit into from
Jul 25, 2022
Merged

feat(module:anchor): sync new properties #7494

merged 1 commit into from
Jul 25, 2022

Conversation

buqiyuan
Copy link
Collaborator

@buqiyuan buqiyuan commented Jun 3, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 3, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #7494 (ddea38c) into master (b038fa2) will increase coverage by 0.03%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master    #7494      +/-   ##
==========================================
+ Coverage   91.64%   91.67%   +0.03%     
==========================================
  Files         498      498              
  Lines       16512    16526      +14     
  Branches     2559     2563       +4     
==========================================
+ Hits        15133    15151      +18     
+ Misses       1056     1048       -8     
- Partials      323      327       +4     
Impacted Files Coverage Δ
components/anchor/anchor-link.component.ts 100.00% <ø> (ø)
components/anchor/anchor.component.ts 97.47% <90.00%> (-1.57%) ⬇️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/core/util/text-measure.ts 92.98% <0.00%> (+0.87%) ⬆️
components/table/src/table/tr-measure.component.ts 91.30% <0.00%> (+4.34%) ⬆️
...ts/table/src/table/table-inner-scroll.component.ts 83.82% <0.00%> (+4.41%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b038fa2...ddea38c. Read the comment docs.

Copy link
Member

@cipchk cipchk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 254b429 into NG-ZORRO:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants