Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:input, input-number, steps): fix styles in components #7522

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

simplejason
Copy link
Member

@simplejason simplejason commented Jun 20, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7514 #7513

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jun 20, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #7522 (2547564) into master (59d6ef4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7522      +/-   ##
==========================================
+ Coverage   91.72%   91.74%   +0.01%     
==========================================
  Files         502      502              
  Lines       16697    16699       +2     
  Branches     2606     2750     +144     
==========================================
+ Hits        15316    15320       +4     
+ Misses       1049     1048       -1     
+ Partials      332      331       -1     
Impacted Files Coverage Δ
.../input-number/input-number-group-slot.component.ts 100.00% <ø> (ø)
components/input/input-group-slot.component.ts 100.00% <ø> (ø)
components/progress/progress.component.ts 95.52% <ø> (ø)
...nents/input-number/input-number-group.component.ts 98.96% <100.00%> (+0.02%) ⬆️
components/input-number/input-number.component.ts 99.60% <100.00%> (+<0.01%) ⬆️
components/input/input-group.component.ts 98.96% <100.00%> (+0.02%) ⬆️
components/input/input.directive.ts 98.57% <100.00%> (+0.02%) ⬆️
components/steps/step.component.ts 96.07% <100.00%> (+0.07%) ⬆️
components/steps/steps.component.ts 100.00% <100.00%> (+5.19%) ⬆️
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d6ef4...2547564. Read the comment docs.

@simplejason simplejason merged commit 222b225 into NG-ZORRO:master Jun 20, 2022
@dertuerke
Copy link

@simplejason i get a error with the new update 13.3.1
cannot access 'NzInputNumberComponent' before initialization

@232650413
Copy link

ERROR ReferenceError: Cannot access 'NzInputNumberComponent' before initialization

@yinchang0626
Copy link

Uncaught ReferenceError: Cannot access 'NzInputNumberComponent' before initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants