-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module: popconfirm): support async close #7533
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7533 +/- ##
==========================================
- Coverage 91.75% 91.72% -0.03%
==========================================
Files 502 502
Lines 16699 16770 +71
Branches 2604 2759 +155
==========================================
+ Hits 15322 15383 +61
- Misses 1047 1053 +6
- Partials 330 334 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. |
a06a3a4
to
5d4103b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
components/popconfirm/popconfirm.ts
Outdated
) | ||
.subscribe(value => { | ||
if (value) { | ||
this.nzOnConfirm.next(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L291-292 & L296-297 could be extracted to a function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
5d4103b
to
b391aee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information