Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:time-picker): support borderless #7547

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

TheBeard30
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7389

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #7547 (a2b4167) into master (64b7389) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a2b4167 differs from pull request most recent head 395a708. Consider uploading reports for the commit 395a708 to get more accurate results

@@           Coverage Diff           @@
##           master    #7547   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files         502      502           
  Lines       16699    16700    +1     
  Branches     2604     2604           
=======================================
+ Hits        15322    15323    +1     
  Misses       1047     1047           
  Partials      330      330           
Impacted Files Coverage Δ
components/time-picker/time-picker.component.ts 90.86% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b7389...395a708. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit a8c3f95 into NG-ZORRO:master Jul 11, 2022
@TheBeard30 TheBeard30 deleted the timepicker-borderless branch July 12, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants