-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:steps): remove top-level redundant div
element
#7582
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7582 +/- ##
==========================================
- Coverage 91.74% 91.73% -0.01%
==========================================
Files 502 502
Lines 16756 16746 -10
Branches 2757 2755 -2
==========================================
- Hits 15372 15362 -10
Misses 1050 1050
Partials 334 334
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first `div` child of the `nz-steps` element is redundant and should be merged with the `nz-steps` element.
I just fixed the demo, do I need to point this PR to the v14 branch? |
thx, no, I'll label it. |
The first
div
child of thenz-steps
element is redundant and should be merged with thenz-steps
element.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is a layer of redundant
div
element under thenz-steps
element.Issue Number: N/A
What is the new behavior?
Remove redundant
div
element.Does this PR introduce a breaking change?
I'm not sure if this introduces breaking changes, but this changes the existing DOM structure.
Other information