feat(module:icon): change tag of nz-icon from <i> to <span> #7586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhudev
requested review from
hsuanxyz,
a team,
simplejason,
vthinkxie,
wenqi73 and
cipchk
as code owners
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## 14.0.x #7586 +/- ##
=======================================
Coverage 92.09% 92.10%
=======================================
Files 502 502
Lines 16739 16747 +8
Branches 2625 2629 +4
=======================================
+ Hits 15416 15424 +8
+ Misses 1056 1055 -1
- Partials 267 268 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
@simplejason Thanks for bugfix and etc. |
simplejason
added a commit
that referenced
this pull request
Aug 4, 2022
* chore: update to v14 chore: update chore: update chore: update to v14 * chore: fix monaco css styles errors * chore: add optionalChainNotNullable to skip errors due to angular bug * chore: update schematics with v14 * chore: update routing to fix errors of ngx-hover-preload * feat(module:icon): change tag of nz-icon from <i> to <span> (#7586) * feat(module:icon): change i tag to span * feat(module:icon): fix some styles after icon changed * feat(module:icon): do not update v9 * feat(module:icon): fix tests Co-authored-by: simplejason <simplejason.coder@gmail.com> * fix(module:icon): add missing nz-icon attribute * chore: update schematics with project name * chore: update package.json of components * chore: fix wrong tag name Co-authored-by: hullis <wendellhu95@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information