-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:date-picker): add nzShowWeekNumber property #7621
feat(module:date-picker): add nzShowWeekNumber property #7621
Conversation
This preview will be available after the AzureCI is passed. |
@wenqi73 I know you guys have a huge stack of open PRs, but do you have any sort of estimate for when this PR might be reviewed? |
@UncleDave CI failed, you should make it run successfully first. |
364c909
to
245af47
Compare
@wenqi73 I'm not familiar with your CI pipeline, but I don't see how my changes could have caused this failure, nor can I reproduce it locally, do you have any clues about it?
|
@UncleDave Run |
@wenqi73 I ran those before my commit, they both succeed for me. |
@UncleDave Maybe you should merge the latest code of master and re-install dependencies? |
245af47
to
86d4e3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #7621 +/- ##
==========================================
+ Coverage 90.43% 91.99% +1.55%
==========================================
Files 502 502
Lines 16752 16738 -14
Branches 2629 2629
==========================================
+ Hits 15150 15398 +248
+ Misses 1314 1072 -242
+ Partials 288 268 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d9ffe94
to
577c336
Compare
@wenqi73 Is there no |
577c336
to
3ddc575
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
03242d5
to
762efa7
Compare
762efa7
to
22a2f21
Compare
22a2f21
to
9f93315
Compare
9f93315
to
21639e0
Compare
21639e0
to
2de6ef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wenqi73 Is there anything else you need from me here? The code cov changes are weird since it says the coverage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Week numbers are only shown in the week picker component.
Issue Number: Fixes #3764
What is the new behavior?
[nzShowWeekNumber]
can control whether week numbers are shown in the date picker. Week numbers are still always shown in the week picker.Does this PR introduce a breaking change?