fix(module:tabs): update active router tab after tabs changed - #7649
Merged
Laffery merged 3 commits intoMar 26, 2025
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7649 +/- ##
==========================================
+ Coverage 91.94% 91.95% +0.01%
==========================================
Files 559 559
Lines 19773 19774 +1
Branches 3050 3050
==========================================
+ Hits 18180 18184 +4
+ Misses 1267 1262 -5
- Partials 326 328 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
laggage
force-pushed
the
fix-link-tab-active-tab-mismatch
branch
from
September 27, 2022 05:29
3c8cc06 to
c9d044e
Compare
laggage
marked this pull request as draft
March 4, 2023 08:24
laggage
force-pushed
the
fix-link-tab-active-tab-mismatch
branch
from
March 4, 2023 12:56
c9d044e to
04467af
Compare
laggage
changed the title
laggage
force-pushed
the
fix-link-tab-active-tab-mismatch
branch
from
March 4, 2023 13:13
04467af to
05d7fd2
Compare
laggage
marked this pull request as ready for review
March 4, 2023 13:48
Contributor
Author
|
I have update the pr Please take a look when you have time, let me know if there any problem in the code, i will try fix it as soon a i can |
Contributor
Author
|
Any further progress on this? It's been nearly two years, and we're still seeing the Menu default to the first page on page refresh. |
Laffery
requested changes
Feb 21, 2025
Laffery
left a comment
Laffery
left a comment
Collaborator
There was a problem hiding this comment.
Please rebase from master
Laffery
added
PR: reviewed-changes-requested
PR: need-rebase
and removed
PR: unreviewed
labels
laggage
force-pushed
the
fix-link-tab-active-tab-mismatch
branch
from
March 26, 2025 03:29
05d7fd2 to
831cd2a
Compare
Contributor
Author
Updated |
laggage
force-pushed
the
fix-link-tab-active-tab-mismatch
branch
from
March 26, 2025 05:09
831cd2a to
dca1082
Compare
Contributor
Author
|
Here is a demo video may better explain the idea Screen.Recording.2025-03-26.at.14.17.36.mov
|
Laffery
requested changes
Mar 26, 2025
| </a> | ||
| Four. | ||
| </nz-tab> | ||
| <nz-tab *ngFor="let tab of dynamicTabs"> |
| tick(); | ||
| fixture.detectChanges(); | ||
|
|
||
| // tabs = fixture.debugElement.query(By.directive(NzTabSetComponent)); |
|
|
||
| @Component({ | ||
| template: ` <nz-tabset nzLinkRouter [(nzSelectedIndex)]="selectedIdx" [nzLinkExact]="false"> | ||
| <nz-tab *ngFor="let tab of tabs"> |
laggage
force-pushed
the
fix-link-tab-active-tab-mismatch
branch
from
March 26, 2025 07:22
dca1082 to
51b18c2
Compare
|
This PR introduced a bug that is also confirmed by other users. Check it here: #9083 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Tabs with Router always select the first tab after a refresh
Issue Number: #4773
What is the new behavior?
Tabs with Router will select the tab match the route after a refresh
Does this PR introduce a breaking change?
Other information
I have added an
ADDbutton to the demo of link router tab which will add a new tab after click; you can try refresh demo page with query paramstab=1(the full path should be/components/tabs/en?tab=1), and click theADDbutton on link router demo, the active tab should switch to the newly added tab with titleNewTab1