Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:time-picker): support input readonly #7660


Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Not support input readonly.

Issue Number: N/A

What is the new behavior?

Support input readonly.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

zorro-bot bot commented Oct 2, 2022

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #7660 (8108926) into master (2d2fe33) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7660      +/-   ##
+ Coverage   92.01%   92.03%   +0.01%     
  Files         502      502              
  Lines       16750    16751       +1     
  Branches     2634     2634              
+ Hits        15413    15417       +4     
+ Misses       1066     1064       -2     
+ Partials      271      270       -1     
Impacted Files Coverage Δ
components/time-picker/time-picker.component.ts 94.05% <100.00%> (+0.03%) ⬆️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️
components/core/util/text-measure.ts 92.98% <0.00%> (+0.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@simplejason simplejason merged commit 2dcefe2 into NG-ZORRO:master Oct 9, 2022
@HyperLife1119 HyperLife1119 deleted the time-picker-support-input-readonly branch December 11, 2022 16:36
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants