Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): fix datePicker can't clear #7671

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

luckyship
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 7534

What is the new behavior?

it can clear range-picker when it has default value

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 11, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #7671 (7c4bb28) into master (16e61be) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7671   +/-   ##
=======================================
  Coverage   92.03%   92.04%           
=======================================
  Files         502      502           
  Lines       16751    16752    +1     
  Branches     2634     2634           
=======================================
+ Hits        15417    15419    +2     
  Misses       1064     1064           
+ Partials      270      269    -1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 93.71% <100.00%> (+0.01%) ⬆️
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️
components/tabs/tab-nav-bar.component.ts 88.65% <0.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wenqi73
Copy link
Member

wenqi73 commented Oct 11, 2022

@luckyship Could you add a unit test for this?

@luckyship
Copy link
Contributor Author

@luckyship Could you add a unit test for this?

sorry, let me add new unit test for this

@luckyship
Copy link
Contributor Author

@wenqi73 i have added new unit test, please check again, thanks

@wenqi73 wenqi73 changed the title fix(module:date-picker): fix datePicker can't clear (#7534) fix(module:date-picker): fix datePicker can't clear Oct 13, 2022
@wenqi73 wenqi73 merged commit ba90876 into NG-ZORRO:master Oct 13, 2022
@wenqi73
Copy link
Member

wenqi73 commented Oct 13, 2022

@luckyship Thanks!

chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants