Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): disabled option can be selected by Enter #7686

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

luckyship
Copy link
Contributor

@luckyship luckyship commented Oct 17, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7681
close: #7681

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #7686 (f78cca7) into master (ee4872e) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head f78cca7 differs from pull request most recent head 91d82cb. Consider uploading reports for the commit 91d82cb to get more accurate results

@@            Coverage Diff             @@
##           master    #7686      +/-   ##
==========================================
- Coverage   92.03%   92.00%   -0.04%     
==========================================
  Files         502      502              
  Lines       16757    16757              
  Branches     2635     2635              
==========================================
- Hits        15423    15417       -6     
- Misses       1064     1072       +8     
+ Partials      270      268       -2     
Impacted Files Coverage Δ
components/select/select.component.ts 91.29% <100.00%> (ø)
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
components/table/src/table-data.service.ts 80.32% <0.00%> (-4.92%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-4.35%) ⬇️
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️
components/table/src/table-style.service.ts 96.55% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luckyship luckyship force-pushed the master branch 4 times, most recently from c7fc989 to aac54c7 Compare October 17, 2022 06:36
@luckyship
Copy link
Contributor Author

@vthinkxie hello, can help review this merge request?

@simplejason simplejason self-requested a review December 11, 2022 03:00
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 5bdf244 into NG-ZORRO:master Dec 11, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-select 使用搜索功能可以搜到禁用的选项
2 participants