Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:time-picker): fix AM/PM selector hide #7701

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

luckyship
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7699
close: #7699

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 26, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #7701 (b86c1e0) into master (ee4872e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7701   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         502      502           
  Lines       16757    16783   +26     
  Branches     2635     2645   +10     
=======================================
+ Hits        15423    15447   +24     
- Misses       1064     1067    +3     
+ Partials      270      269    -1     
Impacted Files Coverage Δ
...ponents/time-picker/time-picker-panel.component.ts 96.81% <ø> (ø)
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-4.35%) ⬇️
components/tree-select/tree-select.component.ts 91.25% <0.00%> (-0.94%) ⬇️
components/carousel/carousel.component.ts 92.81% <0.00%> (-0.48%) ⬇️
components/core/config/config.ts 100.00% <0.00%> (ø)
components/popconfirm/popconfirm.ts 97.80% <0.00%> (ø)
components/icon/icon.directive.ts 97.18% <0.00%> (+0.04%) ⬆️
...mponents/date-picker/date-range-popup.component.ts 95.21% <0.00%> (+0.05%) ⬆️
components/tree/tree.component.ts 94.97% <0.00%> (+0.05%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -459,6 +471,7 @@ export class NzTest12HourTimePanelDisabeledComponent {
@ViewChild(NzTimePickerPanelComponent, { static: false }) nzTimePickerPanelComponent!: NzTimePickerPanelComponent;
format = 'hh:mm:ss a';
value = new Date(0, 0, 0, 1, 1, 1);
hideDisabledOptions = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If hideDisabledOptions should be always false, why don'y you set [nzHideDisabledOptions]="hideDisabledOptions" to be [nzHideDisabledOptions]="false"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i have updated it.

@luckyship luckyship force-pushed the issue-7699 branch 3 times, most recently from 046cf7a to 2d5d641 Compare December 14, 2022 09:01
@luckyship luckyship requested review from simplejason and removed request for wenqi73 December 14, 2022 10:24
@simplejason simplejason merged commit 129e944 into NG-ZORRO:master Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time-picker error: Cannot read properties of undefined (reading 'offsetTop')
2 participants