-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:time-picker): fix AM/PM selector hide #7701
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7701 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 502 502
Lines 16757 16783 +26
Branches 2635 2645 +10
=======================================
+ Hits 15423 15447 +24
- Misses 1064 1067 +3
+ Partials 270 269 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -459,6 +471,7 @@ export class NzTest12HourTimePanelDisabeledComponent { | |||
@ViewChild(NzTimePickerPanelComponent, { static: false }) nzTimePickerPanelComponent!: NzTimePickerPanelComponent; | |||
format = 'hh:mm:ss a'; | |||
value = new Date(0, 0, 0, 1, 1, 1); | |||
hideDisabledOptions = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If hideDisabledOptions
should be always false, why don'y you set [nzHideDisabledOptions]="hideDisabledOptions"
to be [nzHideDisabledOptions]="false"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, i have updated it.
046cf7a
to
2d5d641
Compare
2d5d641
to
b86c1e0
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #7699
close: #7699
What is the new behavior?
Does this PR introduce a breaking change?
Other information