Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:cron-expression): Optimize cron result display & support custom rendering cron time #7750

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

OriginRing
Copy link
Collaborator

@OriginRing OriginRing commented Nov 29, 2022

fix #7745

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

替换Collapse,新增自定义渲染cron时间

@zorro-bot
Copy link

zorro-bot bot commented Nov 29, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #7750 (7075fb0) into master (31c1f77) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7750   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         502      502           
  Lines       16768    16768           
  Branches     2638     2638           
=======================================
  Hits        15437    15437           
  Misses       1062     1062           
  Partials      269      269           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OriginRing OriginRing force-pushed the fix/cron-style branch 2 times, most recently from 3d6ea9f to b1516c7 Compare November 29, 2022 06:54
@OriginRing OriginRing changed the title fix(module:cron-expression): optimize cron style feat(module:cron-expression): brand new cron result display Dec 1, 2022
@OriginRing OriginRing changed the title feat(module:cron-expression): brand new cron result display feat(module:cron-expression): Optimize cron result display, support custom rendering cron time Dec 1, 2022
@OriginRing OriginRing changed the title feat(module:cron-expression): Optimize cron result display, support custom rendering cron time feat(module:cron-expression): Optimize cron result display & support custom rendering cron time Dec 1, 2022
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 1820da5 into NG-ZORRO:master Dec 5, 2022
@pr-triage pr-triage bot added the PR: merged label Dec 5, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
…custom rendering cron time (NG-ZORRO#7750)

* feat(module:cron-expression): brand new cron result display

* feat(module:cron-expression): delete CollapseModule

Co-authored-by: Gyy <wb-gyy965916@alibaba-inc.com>
@OriginRing OriginRing deleted the fix/cron-style branch March 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cron组件的样式定义影响了折叠面板
2 participants