Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:dropdown): improve NzContextMenuService#create() #7768

Merged

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Dec 11, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

NzContextMenuService#create() return void,developer cannot listen to view destroy event.

What is the new behavior?

NzContextMenuService#create() will now return EmbeddedViewRef, developers can listen to view destroy event through EmbeddedViewRef#onDestroy().

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 11, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #7768 (d90eb41) into master (37391de) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head d90eb41 differs from pull request most recent head 678bf15. Consider uploading reports for the commit 678bf15 to get more accurate results

@@            Coverage Diff             @@
##           master    #7768      +/-   ##
==========================================
- Coverage   91.68%   91.66%   -0.02%     
==========================================
  Files         515      515              
  Lines       17634    17634              
  Branches     2789     2789              
==========================================
- Hits        16168    16165       -3     
- Misses       1170     1172       +2     
- Partials      296      297       +1     
Impacted Files Coverage Δ
components/dropdown/context-menu.service.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@HyperLife1119 HyperLife1119 changed the title feat(module:dropdown): improve NzContextMenuService feat(module:dropdown): improve NzContextMenuService#create() Dec 19, 2022
@HyperLife1119 HyperLife1119 force-pushed the dropdown-context-menu-service branch 2 times, most recently from d22ab09 to 7a22a32 Compare March 31, 2023 08:10
@HyperLife1119
Copy link
Collaborator Author

HyperLife1119 commented Mar 31, 2023

It's ready.

@HyperLife1119 HyperLife1119 force-pushed the dropdown-context-menu-service branch from 7a22a32 to 97fd80b Compare April 3, 2023 01:14
@HyperLife1119 HyperLife1119 requested review from a team and OriginRing as code owners April 6, 2023 01:49
@HyperLife1119 HyperLife1119 force-pushed the dropdown-context-menu-service branch from 5881ab3 to 6a8dba2 Compare April 6, 2023 01:51
@HyperLife1119 HyperLife1119 force-pushed the dropdown-context-menu-service branch from 6a8dba2 to ae6a418 Compare June 1, 2023 01:23
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev
Copy link
Member

wzhudev commented Jun 1, 2023

Thanks for contributing. A test case would be better :)

@HyperLife1119 HyperLife1119 force-pushed the dropdown-context-menu-service branch 3 times, most recently from 23e23b9 to fb8a7bd Compare June 2, 2023 09:20
@HyperLife1119
Copy link
Collaborator Author

This PR is ready to be merged. @simplejason @wzhudev @OriginRing

@simplejason simplejason force-pushed the dropdown-context-menu-service branch from fb8a7bd to 678bf15 Compare July 16, 2023 09:03
@simplejason simplejason merged commit 9b3e6cb into NG-ZORRO:master Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants