-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:dropdown): improve NzContextMenuService#create()
#7768
feat(module:dropdown): improve NzContextMenuService#create()
#7768
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7768 +/- ##
==========================================
- Coverage 91.68% 91.66% -0.02%
==========================================
Files 515 515
Lines 17634 17634
Branches 2789 2789
==========================================
- Hits 16168 16165 -3
- Misses 1170 1172 +2
- Partials 296 297 +1
|
NzContextMenuService
NzContextMenuService#create()
d22ab09
to
7a22a32
Compare
It's ready. |
7a22a32
to
97fd80b
Compare
5881ab3
to
6a8dba2
Compare
6a8dba2
to
ae6a418
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing. A test case would be better :) |
23e23b9
to
fb8a7bd
Compare
This PR is ready to be merged. @simplejason @wzhudev @OriginRing |
fb8a7bd
to
678bf15
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
NzContextMenuService#create()
returnvoid
,developer cannot listen to view destroy event.What is the new behavior?
NzContextMenuService#create()
will now returnEmbeddedViewRef
, developers can listen to view destroy event throughEmbeddedViewRef#onDestroy()
.Does this PR introduce a breaking change?
Other information