-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some forms component can't be disable #7786
fix: some forms component can't be disable #7786
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7786 +/- ##
==========================================
- Coverage 92.08% 92.05% -0.04%
==========================================
Files 502 502
Lines 16782 16800 +18
Branches 2562 2570 +8
==========================================
+ Hits 15454 15465 +11
- Misses 1059 1064 +5
- Partials 269 271 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@simplejason can you check this PR when you have a little time. This PR fix some regression due to the bump to angular v15 |
Thanks for your PR :) I will review it ASAP. |
I would assume some updated specs may be appropriate, as this bug was not caught before. |
I am working on it |
What's the progress of this PR? Can I start to review and merge it? |
The PR #7786 is finished and can be reviewed. The Pr regarding the missing test is still in progress on my side. I will try to finished it this week. |
It would be great to get this in ASAP as the current release is partially broken. |
@simplejason @jornare missing test are added |
e0169d1
to
305568b
Compare
@simplejason i think it's goog now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great work guys! Looking forward to getting this in as it is the only thing blocking for my project to go ng15 now :) |
you are missing |
|
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
if the component is bind to a formControl and the property nzDisable is set to true initially the form element will stay enable. This is not the correct behavior. Form component should be disable
Issue Number: 7726 (release v15)
What is the new behavior?
Form component bind by ngModel and property nzDisable set to true are now disable initially (this was the behavior in version 14)
Does this PR introduce a breaking change?
Other information