Skip to content

fix(module:space): nzSpaceItem margin in rtl#7801

Merged
Laffery merged 4 commits into
NG-ZORRO:masterfrom
akg2011-code:bugfix/nzSpace-margin-rtl
Mar 11, 2025
Merged

fix(module:space): nzSpaceItem margin in rtl#7801
Laffery merged 4 commits into
NG-ZORRO:masterfrom
akg2011-code:bugfix/nzSpace-margin-rtl

Conversation

@akg2011-code

Copy link
Copy Markdown
Contributor
  • Change 'margin-right' to 'margin-inline-end' and
    'margin-bottom' to 'margin-block-end' for support any direction

- Change 'margin-right' to 'margin-inline-end' and
'margin-bottom' to 'margin-block-end' for support any direction
@zorro-bot

zorro-bot Bot commented Jan 5, 2023

Copy link
Copy Markdown

This preview will be available after the AzureCI is passed.

@codecov

codecov Bot commented Jan 5, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (13d1869) to head (9bf7f3f).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7801      +/-   ##
==========================================
- Coverage   91.95%   91.95%   -0.01%     
==========================================
  Files         559      559              
  Lines       19772    19769       -3     
  Branches     2954     3050      +96     
==========================================
- Hits        18181    18178       -3     
- Misses       1264     1265       +1     
+ Partials      327      326       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simplejason

simplejason commented Jan 9, 2023

Copy link
Copy Markdown
Member

I find margin-block-end only works on v87+ in caniuse, I'm not sure if this is the best solution.

@akg2011-code

Copy link
Copy Markdown
Contributor Author

I find margin-block-end only works on v87+ in caniuse, I'm not sure if this is the best solution.

What is the lowest version it should be?

@Laffery Laffery added Component: Space 🌐 caniuse blocked by browser compatibility labels Jul 25, 2024
@lppedd

lppedd commented Dec 14, 2024

Copy link
Copy Markdown
Contributor

What is the lowest version it should be?

I think having proper localization (which includes RTL design) is more important than supporting old browsers anyways.

@Laffery

Laffery commented Dec 20, 2024

Copy link
Copy Markdown
Collaborator

What is the lowest version it should be?

I think having proper localization (which includes RTL design) is more important than supporting old browsers anyways.

Nearly two years on, we can look at the latest figures on caniuse, both margin-inline-end and margin-block-end are supported by over 96% of browsers.
Besides, antd had already used margin-inline-end in their components https://github.com/search?q=repo%3Aant-design%2Fant-design+margin-inline-end&type=code.

I think it's time for us to import them in ng-zorro, WDYT? @lppedd

@lppedd

lppedd commented Jan 11, 2025

Copy link
Copy Markdown
Contributor

@Laffery yup, I agree. Generally speaking I'm ok with supporting older browsers, but I always prioritize the code and how easily a feature can be implemented with new options.

@Laffery Laffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery added PR: reviewed-approved and removed PR: need-test Test is necessary for code changes. labels Mar 11, 2025
@Laffery Laffery merged commit 2d9ff5f into NG-ZORRO:master Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants