fix(module:space): nzSpaceItem margin in rtl#7801
Conversation
- Change 'margin-right' to 'margin-inline-end' and 'margin-bottom' to 'margin-block-end' for support any direction
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7801 +/- ##
==========================================
- Coverage 91.95% 91.95% -0.01%
==========================================
Files 559 559
Lines 19772 19769 -3
Branches 2954 3050 +96
==========================================
- Hits 18181 18178 -3
- Misses 1264 1265 +1
+ Partials 327 326 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I find |
What is the lowest version it should be? |
I think having proper localization (which includes RTL design) is more important than supporting old browsers anyways. |
Nearly two years on, we can look at the latest figures on caniuse, both I think it's time for us to import them in ng-zorro, WDYT? @lppedd |
|
@Laffery yup, I agree. Generally speaking I'm ok with supporting older browsers, but I always prioritize the code and how easily a feature can be implemented with new options. |
'margin-bottom' to 'margin-block-end' for support any direction