Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:qrcode): add QRCode component #7803

Merged
merged 9 commits into from
Mar 29, 2023

Conversation

OriginRing
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 9, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #7803 (2209917) into master (3602abc) will decrease coverage by 0.24%.
The diff coverage is 82.43%.

❗ Current head 2209917 differs from pull request most recent head 91e2763. Consider uploading reports for the commit 91e2763 to get more accurate results

@@            Coverage Diff             @@
##           master    #7803      +/-   ##
==========================================
- Coverage   92.08%   91.84%   -0.24%     
==========================================
  Files         502      506       +4     
  Lines       16819    17303     +484     
  Branches     2577     2746     +169     
==========================================
+ Hits        15487    15892     +405     
- Misses       1061     1123      +62     
- Partials      271      288      +17     
Impacted Files Coverage Δ
components/qr-code/qrcode.ts 51.16% <51.16%> (ø)
components/qr-code/qrcodegen.ts 85.12% <85.12%> (ø)
components/qr-code/qrcode.component.ts 90.00% <90.00%> (ø)
components/qr-code/qrcode.module.ts 100.00% <100.00%> (ø)
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+0.70%) ⬆️
components/icon/icon.service.ts 95.58% <0.00%> (+2.94%) ⬆️
components/table/src/table/tr-measure.component.ts 91.30% <0.00%> (+4.34%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OriginRing OriginRing requested a review from vthinkxie as a code owner January 11, 2023 04:18
@OriginRing OriginRing requested review from simplejason and removed request for vthinkxie January 11, 2023 04:19
@OriginRing OriginRing force-pushed the feat/qrcode branch 2 times, most recently from 9787be4 to d3f852d Compare January 11, 2023 05:40
@OriginRing OriginRing force-pushed the feat/qrcode branch 2 times, most recently from bf60af6 to 88c0c30 Compare February 22, 2023 02:04
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit ff36981 into NG-ZORRO:master Mar 29, 2023
@pr-triage pr-triage bot added the PR: merged label Mar 29, 2023
TheBeard30 pushed a commit to TheBeard30/ng-zorro-antd that referenced this pull request Mar 31, 2023
* feat(module:qrcode): add QRCode component

* feat(module:qrcode): add QRCode component fix bug

* feat(module:qrcode): add QRCode component

* feat(module:qrcode): add unit test

* fix(module:qrcode): qr code blurry picture

* fix(module:qrcode): fix pr test error

* fix(module:qrcode): clear canvas when value is empty

* fix(module:qrcode): i18n key corresponds to ant.d

* fix(module:qrcode): correct some spelling problems
@OriginRing OriginRing deleted the feat/qrcode branch March 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants