Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:checkbox): chebox group can't be disable initially #7806

Merged

Conversation

Nicoss54
Copy link
Collaborator

@Nicoss54 Nicoss54 commented Jan 10, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

Fix a regression on disabling radio group and checkbox group initially if form is enable and input nzDisabled is set to true

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Radio Group and Checkbox group is enabled if form is initially enable and input nzDisabled is set to true

Issue Number

What is the new behavior?

Radio Group and Checkbox group is disabled if form is initially enable and input nzDisabled is set to true

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: draft label Jan 10, 2023
@zorro-bot
Copy link

zorro-bot bot commented Jan 10, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #7806 (5ff3707) into master (9f7e256) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7806      +/-   ##
==========================================
+ Coverage   92.06%   92.09%   +0.03%     
==========================================
  Files         502      502              
  Lines       16800    16804       +4     
  Branches     2570     2572       +2     
==========================================
+ Hits        15467    15476       +9     
+ Misses       1063     1056       -7     
- Partials      270      272       +2     
Impacted Files Coverage Δ
components/checkbox/checkbox-group.component.ts 100.00% <100.00%> (ø)
components/radio/radio-group.component.ts 97.95% <100.00%> (+0.08%) ⬆️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/table/src/table/tr-measure.component.ts 91.30% <0.00%> (+4.34%) ⬆️
...ts/table/src/table/table-inner-scroll.component.ts 83.82% <0.00%> (+4.41%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Nicoss54 Nicoss54 marked this pull request as ready for review January 10, 2023 09:51
@Nicoss54 Nicoss54 requested a review from vthinkxie as a code owner January 10, 2023 09:51
@Nicoss54
Copy link
Collaborator Author

@simplejason, this PR follows the previous one which fixes the disable problem with form components.
The RadioGroup and CheckboxGroup components were missing

Sorry about that

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason
Copy link
Member

simplejason commented Jan 10, 2023

@simplejason, this PR follows the previous one which fixes the disable problem with form components. The RadioGroup and CheckboxGroup components were missing

Sorry about that

Thanks for your contributions, I will release 15.0.2 ASAP :)

@simplejason simplejason merged commit eb2cb04 into NG-ZORRO:master Jan 13, 2023
@Nicoss54 Nicoss54 deleted the fix/checkbox-radio-group-disabling branch January 17, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants