Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:radio): invalid disable state #7812

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

Nicoss54
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

Fix a regression on disabling state of radio button in a radio group

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

If radio-group is used with an enable formControl allthe radio button of this radio group are enable even if the nzDisable property is set to true

Issue Number: 7811

What is the new behavior?

If radio-group is used with an enable formControl all the radio button disable state must respect the value of NzDisabled property initially

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #7812 (844899c) into master (532d6ef) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 844899c differs from pull request most recent head 671e5c3. Consider uploading reports for the commit 671e5c3 to get more accurate results

@@            Coverage Diff             @@
##           master    #7812      +/-   ##
==========================================
- Coverage   92.08%   92.07%   -0.02%     
==========================================
  Files         502      502              
  Lines       16807    16808       +1     
  Branches     2572     2573       +1     
==========================================
- Hits        15477    15476       -1     
- Misses       1057     1059       +2     
  Partials      273      273              
Impacted Files Coverage Δ
components/radio/radio.component.ts 97.70% <100.00%> (+0.02%) ⬆️
components/tabs/tab-nav-bar.component.ts 86.52% <0.00%> (-0.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Nicoss54
Copy link
Collaborator Author

@simplejason if you are agree with this fix, i can merge it :)

@simplejason
Copy link
Member

@simplejason if you are agree with this fix, i can merge it :)

Cool, we can merge it and release v15.0.3 today :)

@Nicoss54 Nicoss54 merged commit 2b4df9a into NG-ZORRO:master Jan 17, 2023
@pr-triage pr-triage bot added the PR: merged label Jan 17, 2023
@Nicoss54
Copy link
Collaborator Author

@simplejason merged

@Nicoss54 Nicoss54 deleted the fix/disabling-state-radio-group branch January 17, 2023 08:17
@simplejason
Copy link
Member

@simplejason merged

I will create a PR for v15.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants