Skip to content

fix(module:datepicker): send OnChange event for same value #7815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Nicoss54
Copy link
Collaborator

@Nicoss54 Nicoss54 commented Jan 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

valueChange/ngModelChange is notified event if value don't change

Issue Number: #7814

What is the new behavior?

valueChange / ngModelChange is not notified anymore if value not change

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 22, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Merging #7815 (9e07e67) into master (445d183) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7815   +/-   ##
=======================================
  Coverage   92.09%   92.10%           
=======================================
  Files         502      502           
  Lines       16808    16819   +11     
  Branches     2573     2577    +4     
=======================================
+ Hits        15480    15491   +11     
  Misses       1056     1056           
  Partials      272      272           
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 94.64% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicoss54 Nicoss54 merged commit 3602abc into NG-ZORRO:master Feb 4, 2023
@pr-triage pr-triage bot added the PR: merged label Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants