-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:modal): pass data to modal component through injection token #7849
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7849 +/- ##
===========================================
- Coverage 91.81% 20.24% -71.57%
===========================================
Files 506 506
Lines 17302 17304 +2
Branches 2747 2748 +1
===========================================
- Hits 15886 3504 -12382
- Misses 1130 13775 +12645
+ Partials 286 25 -261
... and 340 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nice work! |
thanks and thanks a lot for the great discussion we had :) |
Please rebase this with master to resolve all conflicts :) After that, I will merge this PR before next version. |
deprecate nzComponentParams
df200e7
to
e8ec650
Compare
@simplejason it's done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ken (NG-ZORRO#7849) * feat(module:modal): pass data to modal component through injection token deprecate nzComponentParams * test(module:datepicker): fix test nzPlacement doest not work anymore * test(module:qrcode): fix test, icon not registered * test(module:tooltip): comment a test. Failed on CI but not on Local
deprecate nzComponentParams
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently data pass to a custom component when nzContent is a component are retrieved thanks to nzComponentParams
Issue Number: N/A
What is the new behavior?
Now nzComponentParams property is deprecated, and data pass to a custom component when nzContent is a component are retrieved thanks to the Nz_MODAL_DATA injection token
Does this PR introduce a breaking change?
nzComponentParams property is now deprecated
Other information