Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): pass data to modal component through injection token #7849

Merged
merged 4 commits into from
Mar 31, 2023

Conversation

Nicoss54
Copy link
Collaborator

@Nicoss54 Nicoss54 commented Feb 24, 2023

deprecate nzComponentParams

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently data pass to a custom component when nzContent is a component are retrieved thanks to nzComponentParams

Issue Number: N/A

What is the new behavior?

Now nzComponentParams property is deprecated, and data pass to a custom component when nzContent is a component are retrieved thanks to the Nz_MODAL_DATA injection token

Does this PR introduce a breaking change?

[ ] Yes
[x] No

nzComponentParams property is now deprecated

Other information

@Nicoss54 Nicoss54 requested a review from hsuanxyz as a code owner February 24, 2023 21:51
@zorro-bot
Copy link

zorro-bot bot commented Feb 24, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #7849 (42d9390) into master (1c48745) will decrease coverage by 71.57%.
The diff coverage is 10.00%.

❗ Current head 42d9390 differs from pull request most recent head 47bc8a9. Consider uploading reports for the commit 47bc8a9 to get more accurate results

@@             Coverage Diff             @@
##           master    #7849       +/-   ##
===========================================
- Coverage   91.81%   20.24%   -71.57%     
===========================================
  Files         506      506               
  Lines       17302    17304        +2     
  Branches     2747     2748        +1     
===========================================
- Hits        15886     3504    -12382     
- Misses       1130    13775    +12645     
+ Partials      286       25      -261     
Impacted Files Coverage Δ
components/modal/modal-types.ts 5.00% <0.00%> (-95.00%) ⬇️
components/modal/modal.service.ts 21.21% <0.00%> (-74.71%) ⬇️
components/modal/modal-config.ts 100.00% <100.00%> (ø)

... and 340 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MunMunMiao
Copy link
Collaborator

nice work!

@Nicoss54
Copy link
Collaborator Author

nice work!

thanks and thanks a lot for the great discussion we had :)

@simplejason
Copy link
Member

Please rebase this with master to resolve all conflicts :) After that, I will merge this PR before next version.

@Nicoss54 Nicoss54 force-pushed the feature/modal-nzData branch from df200e7 to e8ec650 Compare March 29, 2023 10:19
@Nicoss54
Copy link
Collaborator Author

Nicoss54 commented Mar 29, 2023

Please rebase this with master to resolve all conflicts :) After that, I will merge this PR before next version.

@simplejason it's done

@Nicoss54 Nicoss54 requested a review from wzhudev as a code owner March 29, 2023 12:39
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit ea9969d into NG-ZORRO:master Mar 31, 2023
@pr-triage pr-triage bot added the PR: merged label Mar 31, 2023
TheBeard30 pushed a commit to TheBeard30/ng-zorro-antd that referenced this pull request Mar 31, 2023
…ken (NG-ZORRO#7849)

* feat(module:modal): pass data to modal component through injection token

deprecate nzComponentParams

* test(module:datepicker): fix test nzPlacement doest not work anymore

* test(module:qrcode): fix test, icon not registered

* test(module:tooltip): comment a test. Failed on CI but not on Local
@Nicoss54 Nicoss54 deleted the feature/modal-nzData branch April 14, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants