Skip to content

perf(module:select): remove unused types #7850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

xucr11
Copy link
Contributor

@xucr11 xucr11 commented Feb 25, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

none

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 25, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Merging #7850 (383383a) into master (e95cdb6) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 383383a differs from pull request most recent head c4d3bb3. Consider uploading reports for the commit c4d3bb3 to get more accurate results

@@            Coverage Diff             @@
##           master    #7850      +/-   ##
==========================================
- Coverage   92.09%   92.08%   -0.02%     
==========================================
  Files         502      502              
  Lines       16819    16819              
  Branches     2577     2662      +85     
==========================================
- Hits        15489    15487       -2     
- Misses       1059     1061       +2     
  Partials      271      271              
Impacted Files Coverage Δ
components/select/select-top-control.component.ts 93.75% <100.00%> (ø)
components/tabs/tab-add-button.component.ts 75.00% <0.00%> (-25.00%) ⬇️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-4.35%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (+0.70%) ⬆️
components/table/src/table-style.service.ts 96.55% <0.00%> (+1.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simplejason simplejason merged commit 71c2138 into NG-ZORRO:master Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants