Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:watermark): add watermark component #7857

Merged
merged 4 commits into from
Apr 2, 2023

Conversation

OriginRing
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 3, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #7857 (8a6819c) into master (3dfa655) will decrease coverage by 0.05%.
The diff coverage is 86.75%.

❗ Current head 8a6819c differs from pull request most recent head 250f38b. Consider uploading reports for the commit 250f38b to get more accurate results

@@            Coverage Diff             @@
##           master    #7857      +/-   ##
==========================================
- Coverage   91.79%   91.74%   -0.05%     
==========================================
  Files         506      509       +3     
  Lines       17304    17455     +151     
  Branches     2748     2770      +22     
==========================================
+ Hits        15884    16014     +130     
- Misses       1128     1144      +16     
- Partials      292      297       +5     
Impacted Files Coverage Δ
components/water-mark/util.ts 70.00% <70.00%> (ø)
components/water-mark/water-mark.component.ts 89.23% <89.23%> (ø)
components/water-mark/water-mark.module.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OriginRing OriginRing force-pushed the feat/Watermar branch 2 times, most recently from 39fa69e to 233940c Compare March 3, 2023 05:42
@OriginRing OriginRing force-pushed the feat/Watermar branch 3 times, most recently from 9b961f8 to 440848e Compare March 6, 2023 06:23
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 11b85a4 into NG-ZORRO:master Apr 2, 2023
@OriginRing OriginRing deleted the feat/Watermar branch March 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants