Skip to content

perf(module:date-picker): do not trigger change detection on mousedown #7860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Mar 3, 2023

No description provided.

@arturovt arturovt requested a review from wenqi73 as a code owner March 3, 2023 19:29
@zorro-bot
Copy link

zorro-bot bot commented Mar 3, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #7860 (4cfc997) into master (e95cdb6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 4cfc997 differs from pull request most recent head 9f2bacb. Consider uploading reports for the commit 9f2bacb to get more accurate results

@@            Coverage Diff             @@
##           master    #7860      +/-   ##
==========================================
+ Coverage   92.09%   92.10%   +0.01%     
==========================================
  Files         502      502              
  Lines       16819    16818       -1     
  Branches     2577     2663      +86     
==========================================
+ Hits        15489    15490       +1     
+ Misses       1059     1056       -3     
- Partials      271      272       +1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 94.62% <100.00%> (-0.02%) ⬇️
components/tabs/tab-add-button.component.ts 75.00% <0.00%> (-25.00%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+1.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 1171460 into NG-ZORRO:master Mar 29, 2023
@arturovt arturovt deleted the perf/date-picker-mousedown branch March 29, 2023 11:54
TheBeard30 pushed a commit to TheBeard30/ng-zorro-antd that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants