Skip to content

feat(module:form): support form label align #7870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

TheBeard30
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 10, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #7870 (ecd5996) into master (ea9969d) will decrease coverage by 0.01%.
The diff coverage is 11.11%.

❗ Current head ecd5996 differs from pull request most recent head 672fa9c. Consider uploading reports for the commit 672fa9c to get more accurate results

@@            Coverage Diff             @@
##           master    #7870      +/-   ##
==========================================
- Coverage   20.24%   20.24%   -0.01%     
==========================================
  Files         506      506              
  Lines       17304    17313       +9     
  Branches     2748     2749       +1     
==========================================
+ Hits         3504     3505       +1     
- Misses      13775    13783       +8     
  Partials       25       25              
Impacted Files Coverage Δ
components/form/form.directive.ts 9.67% <0.00%> (-0.33%) ⬇️
components/form/form-label.component.ts 15.38% <12.50%> (-0.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TheBeard30 TheBeard30 force-pushed the form-label-align branch 2 times, most recently from d717ae9 to 0a609f2 Compare March 29, 2023 11:06
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit d54b3b4 into NG-ZORRO:master Mar 31, 2023
@TheBeard30 TheBeard30 deleted the form-label-align branch October 16, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants