Skip to content

feat(module:float-button): add float-button component#7884

Merged
Laffery merged 7 commits intoNG-ZORRO:masterfrom
OriginRing:feat/float-button
Nov 20, 2024
Merged

feat(module:float-button): add float-button component#7884
Laffery merged 7 commits intoNG-ZORRO:masterfrom
OriginRing:feat/float-button

Conversation

@OriginRing
Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link
Copy Markdown

zorro-bot bot commented Mar 24, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2023

Codecov Report

Attention: Patch coverage is 87.91946% with 18 lines in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (5fec53e) to head (792dec0).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...nents/float-button/float-button-group.component.ts 81.48% 8 Missing and 2 partials ⚠️
...ponents/float-button/float-button-top.component.ts 91.17% 5 Missing and 1 partial ⚠️
components/float-button/float-button.component.ts 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7884      +/-   ##
==========================================
+ Coverage   91.84%   91.85%   +0.01%     
==========================================
  Files         537      542       +5     
  Lines       18472    18620     +148     
  Branches     2815     2828      +13     
==========================================
+ Hits        16965    17103     +138     
- Misses       1204     1209       +5     
- Partials      303      308       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@OriginRing OriginRing force-pushed the feat/float-button branch 12 times, most recently from fdf4a4b to c912897 Compare March 31, 2023 05:44
@Laffery Laffery self-requested a review August 16, 2023 06:05
@NRaf
Copy link
Copy Markdown

NRaf commented Jan 15, 2024

Hi,

Just came across this feature in the React branch and noticed it's missing from ng-zorro. Any idea on when this will be merged in?

@OriginRing OriginRing force-pushed the feat/float-button branch 3 times, most recently from 7987e23 to 2f3d43f Compare March 11, 2024 09:26
@OriginRing OriginRing force-pushed the feat/float-button branch 4 times, most recently from 0b06a0f to 4a5678d Compare July 17, 2024 09:23
@OriginRing OriginRing requested a review from cipchk as a code owner July 18, 2024 03:24
@OriginRing OriginRing force-pushed the feat/float-button branch 2 times, most recently from b8d45da to 5cc525e Compare July 18, 2024 03:43
Comment thread components/float-button/demo/group-menu.md Outdated
Comment thread components/float-button/demo/group.md
Comment thread components/float-button/doc/index.en-US.md Outdated
Comment thread components/float-button/float-button-content.component.ts Outdated
Comment thread components/float-button/float-button-group.component.ts Outdated
Comment thread components/float-button/float-button.component.ts Outdated
Copy link
Copy Markdown
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread scripts/site/template/ng-zorro-antd.module.template.ts
Comment thread components/float-button/doc/index.zh-CN.md Outdated
Comment thread components/float-button/doc/index.en-US.md Outdated
@Laffery Laffery merged commit dab4d66 into NG-ZORRO:master Nov 20, 2024
cover: https://gw.alipayobjects.com/zos/alicdn/tJZ5jbTwX/BackTop.svg
---

* Note: This component will be removed later. Please use `<nz-float-button-top></nz-float-button-top>` in the FloatButton component.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, does that mean the backtop component is to be considered deprecated?
Is it in preparation for Ant Design 5?

@OriginRing OriginRing deleted the feat/float-button branch March 5, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants