feat(module:float-button): add float-button component#7884
Merged
Laffery merged 7 commits intoNG-ZORRO:masterfrom Nov 20, 2024
Merged
feat(module:float-button): add float-button component#7884Laffery merged 7 commits intoNG-ZORRO:masterfrom
Laffery merged 7 commits intoNG-ZORRO:masterfrom
Conversation
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7884 +/- ##
==========================================
+ Coverage 91.84% 91.85% +0.01%
==========================================
Files 537 542 +5
Lines 18472 18620 +148
Branches 2815 2828 +13
==========================================
+ Hits 16965 17103 +138
- Misses 1204 1209 +5
- Partials 303 308 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
fdf4a4b to
c912897
Compare
c912897 to
10bde31
Compare
|
Hi, Just came across this feature in the React branch and noticed it's missing from ng-zorro. Any idea on when this will be merged in? |
7987e23 to
2f3d43f
Compare
0b06a0f to
4a5678d
Compare
b8d45da to
5cc525e
Compare
Laffery
requested changes
Aug 31, 2024
f619fe5 to
1ea8a74
Compare
1ea8a74 to
806be0f
Compare
806be0f to
1508c5f
Compare
Laffery
requested changes
Nov 19, 2024
32e4339 to
792dec0
Compare
lppedd
reviewed
Nov 25, 2024
| cover: https://gw.alipayobjects.com/zos/alicdn/tJZ5jbTwX/BackTop.svg | ||
| --- | ||
|
|
||
| * Note: This component will be removed later. Please use `<nz-float-button-top></nz-float-button-top>` in the FloatButton component. |
Contributor
There was a problem hiding this comment.
Just wondering, does that mean the backtop component is to be considered deprecated?
Is it in preparation for Ant Design 5?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information