Skip to content

feat(module:table): nzExpand supports custom icon #7886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

OriginRing
Copy link
Collaborator

fix: #7882

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 29, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #7886 (b212616) into master (e22433a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head b212616 differs from pull request most recent head ef63842. Consider uploading reports for the commit ef63842 to get more accurate results

@@            Coverage Diff             @@
##           master    #7886      +/-   ##
==========================================
- Coverage   91.78%   91.75%   -0.03%     
==========================================
  Files         509      509              
  Lines       17437    17438       +1     
  Branches     2771     2771              
==========================================
- Hits        16004    16001       -3     
- Misses       1134     1137       +3     
- Partials      299      300       +1     
Impacted Files Coverage Δ
components/table/src/cell/td-addon.component.ts 83.87% <100.00%> (+0.53%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OriginRing OriginRing force-pushed the feat/table-expandIcon branch from b78407c to ef63842 Compare April 3, 2023 01:51
@lw-like
Copy link

lw-like commented Sep 19, 2023

Is there another way to change expand icon? I'm strictly interested in this topic.

@simplejason simplejason merged commit 1507ed0 into NG-ZORRO:master Nov 17, 2023
@OriginRing OriginRing deleted the feat/table-expandIcon branch March 8, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-table row expand icon
3 participants