-
Notifications
You must be signed in to change notification settings - Fork 4k
feat(module:form): support form label wrap #7892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7892 +/- ##
==========================================
- Coverage 91.80% 91.79% -0.01%
==========================================
Files 509 509
Lines 17452 17461 +9
Branches 2684 2685 +1
==========================================
+ Hits 16022 16029 +7
- Misses 1136 1138 +2
Partials 294 294
|
@@ -81,6 +85,17 @@ export class NzFormLabelComponent implements OnDestroy { | |||
} | |||
private _tooltipIcon: NzFormTooltipIcon | 'default' = 'default'; | |||
|
|||
@Input() | |||
set nzLabelWrap(value: boolean) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use @InputBoolean() instead of getter?
<nz-form-label nzLabelWrap></nz-form-label>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also you need to rebase this with the master branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay👌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use @InputBoolean() instead of getter?
<nz-form-label nzLabelWrap></nz-form-label>
If the nzLabelWrap of the NzFormLabelComponent has no value, we
need to get the nzLabelWrap of the Form Directive, so i think we need to use getter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@InputBoolean() will automatically set this property to be true, check other components that use this decorator like select
b845863
to
3baa48e
Compare
3baa48e
to
d547d7c
Compare
d547d7c
to
ae04d6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information