Skip to content

feat(module:table): add nzLabel to include aria-label in checkboxes #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oestrogen
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

It's impossible to add an accessible label to the built-in checkboxes in tables, making screen readers just read "checkbox" over and over again when tabbing through a table.

What is the new behavior?

It is possible to set an aria-label on checkboxes in ths and tds with nzShowCheckbox (or nzChecked, etc.)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 5, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #7903 (9314e9b) into master (538ef21) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

❗ Current head 9314e9b differs from pull request most recent head 38e17a7. Consider uploading reports for the commit 38e17a7 to get more accurate results

@@            Coverage Diff             @@
##           master    #7903      +/-   ##
==========================================
- Coverage   91.78%   91.77%   -0.02%     
==========================================
  Files         509      509              
  Lines       17444    17447       +3     
  Branches     2772     2772              
==========================================
+ Hits        16011    16012       +1     
- Misses       1134     1136       +2     
  Partials      299      299              
Impacted Files Coverage Δ
components/table/src/addon/selection.component.ts 7.69% <0.00%> (-0.65%) ⬇️
...omponents/table/src/cell/th-selection.component.ts 22.22% <0.00%> (-0.86%) ⬇️
components/table/src/cell/td-addon.component.ts 83.87% <100.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@OriginRing OriginRing merged commit 5834e46 into NG-ZORRO:master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants