Skip to content

fix(module:autocomplete): fix the wrong value of internal nz-auto-option#7907

Merged
OriginRing merged 1 commit intoNG-ZORRO:masterfrom
HyperLife1119:fix-autocomplete-data-source
Nov 14, 2023
Merged

fix(module:autocomplete): fix the wrong value of internal nz-auto-option#7907
OriginRing merged 1 commit intoNG-ZORRO:masterfrom
HyperLife1119:fix-autocomplete-data-source

Conversation

@HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Apr 11, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Fix the problem that when the dataSource is an object array, the value of the internal nz-auto-option is set incorrectly.

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 11, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #7907 (2c18761) into master (169181c) will decrease coverage by 0.15%.
The diff coverage is 85.08%.

❗ Current head 2c18761 differs from pull request most recent head 17fa273. Consider uploading reports for the commit 17fa273 to get more accurate results

@@            Coverage Diff             @@
##           master    #7907      +/-   ##
==========================================
- Coverage   91.80%   91.65%   -0.15%     
==========================================
  Files         509      515       +6     
  Lines       17452    17647     +195     
  Branches     2684     2791     +107     
==========================================
+ Hits        16022    16175     +153     
- Misses       1136     1175      +39     
- Partials      294      297       +3     
Impacted Files Coverage Δ
components/modal/modal-footer.component.ts 100.00% <ø> (ø)
components/modal/modal-types.ts 100.00% <ø> (ø)
components/modal/modal.component.ts 95.83% <ø> (ø)
components/modal/modal.service.ts 95.87% <ø> (-0.09%) ⬇️
components/modal/utils.ts 100.00% <ø> (ø)
components/resizable/resizable.directive.ts 95.32% <0.00%> (ø)
components/table/src/table.module.ts 100.00% <ø> (ø)
components/tree/tree-node.component.ts 91.93% <0.00%> (-2.06%) ⬇️
components/qr-code/qrcode.ts 58.06% <72.00%> (+6.90%) ⬆️
components/form/form-label.component.ts 79.54% <75.00%> (-1.02%) ⬇️
... and 17 more

... and 4 files with indirect coverage changes

@HyperLife1119 HyperLife1119 force-pushed the fix-autocomplete-data-source branch from 40b6fb4 to bf1ff33 Compare June 1, 2023 01:24
@HyperLife1119 HyperLife1119 force-pushed the fix-autocomplete-data-source branch from bf1ff33 to 17fa273 Compare July 16, 2023 12:12
@HyperLife1119
Copy link
Collaborator Author

The PR is ready. @hsuanxyz

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119
Copy link
Collaborator Author

When can we merge it? @OriginRing @simplejason

@OriginRing OriginRing merged commit 0a312e3 into NG-ZORRO:master Nov 14, 2023
MunMunMiao pushed a commit to MunMunMiao/ng-zorro-antd that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants