Skip to content

fix(module:date-picker): ng-untouched when loose focus #7922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2023

Conversation

Nicoss54
Copy link
Collaborator

@Nicoss54 Nicoss54 commented Apr 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

This PR introduce a bug fix.

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Before this PR, when the user loose the focus without selected a value of date-picker input, datapicker control stay untouched

Issue Number: #7879

What is the new behavior?

When the user loose the focus without selected a date, datePicker control become touched

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@Nicoss54 Nicoss54 requested a review from wenqi73 as a code owner April 22, 2023 13:40
@Nicoss54 Nicoss54 self-assigned this Apr 22, 2023
@zorro-bot
Copy link

zorro-bot bot commented Apr 22, 2023

This preview will be available after the AzureCI is passed.

@Nicoss54 Nicoss54 linked an issue Apr 22, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #7922 (0a0fde5) into master (59143d2) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 0a0fde5 differs from pull request most recent head 68f4773. Consider uploading reports for the commit 68f4773 to get more accurate results

@@            Coverage Diff             @@
##           master    #7922      +/-   ##
==========================================
- Coverage   91.78%   91.74%   -0.04%     
==========================================
  Files         509      509              
  Lines       17444    17445       +1     
  Branches     2683     2683              
==========================================
- Hits        16011    16005       -6     
- Misses       1134     1142       +8     
+ Partials      299      298       -1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 94.64% <100.00%> (+0.01%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Nicoss54 Nicoss54 merged commit 9ebcf72 into NG-ZORRO:master May 9, 2023
@Nicoss54 Nicoss54 deleted the fix/ng-untouched-date-picker branch May 9, 2023 20:04
MunMunMiao pushed a commit to MunMunMiao/ng-zorro-antd that referenced this pull request May 31, 2023
simplejason pushed a commit to simplejason/ng-zorro-antd that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-date-picker ng-untouched class does not update on touch
2 participants