Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): Remove nzComponentParams in v16 #7930

Merged

Conversation

MunMunMiao
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7827

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@MunMunMiao MunMunMiao requested a review from hsuanxyz as a code owner May 4, 2023 06:44
@zorro-bot
Copy link

zorro-bot bot commented May 4, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #7930 (4eb9c51) into master (169181c) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 4eb9c51 differs from pull request most recent head 70bfbfc. Consider uploading reports for the commit 70bfbfc to get more accurate results

@@            Coverage Diff             @@
##           master    #7930      +/-   ##
==========================================
- Coverage   91.80%   91.79%   -0.01%     
==========================================
  Files         509      509              
  Lines       17452    17448       -4     
  Branches     2684     2683       -1     
==========================================
- Hits        16022    16017       -5     
- Misses       1136     1137       +1     
  Partials      294      294              
Impacted Files Coverage Δ
components/modal/modal-footer.component.ts 100.00% <ø> (ø)
components/modal/modal-types.ts 100.00% <ø> (ø)
components/modal/modal.component.ts 95.83% <ø> (ø)
components/modal/modal.service.ts 95.87% <ø> (-0.09%) ⬇️
components/modal/utils.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@Nicoss54
Copy link
Collaborator

Nicoss54 commented May 4, 2023

LGTM :)

@Nicoss54
Copy link
Collaborator

@MunMunMiao could you rebase your branch ?

@MunMunMiao MunMunMiao force-pushed the feat/remove_modal_component_params branch from 946711e to 70bfbfc Compare May 31, 2023 11:56
@MunMunMiao
Copy link
Collaborator Author

@MunMunMiao could you rebase your branch ?

ok. done

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit baab16c into NG-ZORRO:master Jul 16, 2023
@MunMunMiao MunMunMiao deleted the feat/remove_modal_component_params branch September 20, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants