Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:slider): the first disable is invalid #7947

Merged
merged 1 commit into from
May 15, 2023

Conversation

OriginRing
Copy link
Collaborator

fix #7943

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 15, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #7947 (bbfaf53) into master (538ef21) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head bbfaf53 differs from pull request most recent head 6c88d51. Consider uploading reports for the commit 6c88d51 to get more accurate results

@@            Coverage Diff             @@
##           master    #7947      +/-   ##
==========================================
- Coverage   91.78%   91.74%   -0.04%     
==========================================
  Files         509      509              
  Lines       17444    17445       +1     
  Branches     2772     2683      -89     
==========================================
- Hits        16011    16005       -6     
- Misses       1134     1142       +8     
+ Partials      299      298       -1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 94.64% <100.00%> (+0.01%) ⬆️
components/slider/slider.component.ts 92.36% <100.00%> (ø)

... and 5 files with indirect coverage changes

@Nicoss54 Nicoss54 self-requested a review May 15, 2023 08:19
@Nicoss54
Copy link
Collaborator

LGTM

@Nicoss54 Nicoss54 merged commit ad2faf4 into NG-ZORRO:master May 15, 2023
MunMunMiao pushed a commit to MunMunMiao/ng-zorro-antd that referenced this pull request May 31, 2023
@OriginRing OriginRing deleted the fix/slider branch March 8, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider disabled state not honoured without change
2 participants